Add ISRs to kt topics -replicas
#53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get access to the `client.InSyncReplicas` function, added here: IBM/sarama#872
fgeller
requested changes
May 2, 2017
topic.go
Outdated
| NewestOffset int64 `json:"newest"` | ||
| Leader string `json:"leader,omitempty"` | ||
| Replicas []int32 `json:"replicas,omitempty"` | ||
| Isrs []int32 `json:"isrs,omitempty"` |
There was a problem hiding this comment.
@pd could you rename this to ISRs? cf https://github.com/golang/go/wiki/CodeReviewComments#initialisms
|
Nah, I know nothing of sarama's release schedule. If you normally wait for a tagged release version before vendoring it here, that makes sense to me, and I'll try to keep an eye on sarama. |
|
@pd cheers! not too concerned about using untagged releases for master, just for the next tagged release for kt. But might just perform a bit more testing for that myself when the time has come - I'm assume you're happy installing kt via thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sarama.Client.InSyncReplicasjust landed upstream in sarama; I've updated the vendored version, and now include ISRs if replica information was requested fromkt topics.Many thanks for
kt, which makes writing tooling around Kafka so much easier than the default Kafka CLI tools. Pretty sure this was my final use case for ever callingkafka-topics.sh. 🎉