produce messages partitioned by value #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgeller
reviewed
Dec 4, 2020
| if msg.Value != nil && cmd.partitioner == "hashCodeByValue" { | ||
| part = hashCodePartition(*msg.Value, partitionCount) | ||
| msg.Partition = &part | ||
| }else { |
There was a problem hiding this comment.
could you please run gofmt or your alternative on this? 🙏
There was a problem hiding this comment.
and would it make sense to group the guards slightly differently?
if msg.Partition == nil {
if msg.Value != nil && cmd.partitioner == "hashCodeByValue" {
part = hashCodePartition(*msg.Value, partitionCount)
msg.Partition = &part
} else if msg.Key != nil && cmd.partitioner == "hashCode" {
part = hashCodePartition(*msg.Key, partitionCount)
msg.Partition = &part
}
}
fgeller
reviewed
Dec 4, 2020
| $ echo 'no key specified message' | kt produce -topic greetings -partitioner hashCodeByValue | ||
| Sent message to a partition decided by your case | ||
There was a problem hiding this comment.
awesome! thanks for adding an example and doc in general!
|
hey @LucasDove ! sorry for the delay, and thanks very much for your time and contribution! i suggested two small changes (gofmt & regrouping of guards) - would you mind doing these or should I pull your changes in and perform the changes? |
|
FYI: if you rebase / merge current master, the CI should switch over to GH actions and work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want this feature because in my case, I just want every each partition of a topic could have messages without setting partition key for every message.