Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add linux arm support for nodegit #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2024
Merged

add linux arm support for nodegit #7

merged 1 commit into from
Jan 30, 2024

Conversation

@jgao54
Copy link

@jgao54 jgao54 commented Jan 30, 2024 •
edited
Loading

  • Add arm64 support for linux
  • Bump darwin support to latest (macos-12) runner (gha no longer suports macos-10), this triggered python3 compatibility bug and required upgrading node-gyp
  • Remove Node 14, keeping 16 around until we upgrade to node 20

GHA finally introduced m1 beta support. I tried it and some tests were failing, going to keep this PR just to linux arm support for now.

@jgao54 jgao54 force-pushed the joygao/arm64-support branch from 8af9c10 to 86cd266 Compare January 30, 2024 12:56
@jgao54 jgao54 changed the title test add linux arm support for nodegit Jan 30, 2024
@jgao54 jgao54 changed the title add linux arm support for nodegit add arm support for nodegit Jan 30, 2024
@jgao54 jgao54 force-pushed the joygao/arm64-support branch 2 times, most recently from b3e9765 to 3d47ec0 Compare January 30, 2024 19:00
@jgao54 jgao54 changed the title add arm support for nodegit add linux arm support for nodegit Jan 30, 2024
@jgao54 jgao54 requested a review from jfirebaugh January 30, 2024 19:08
@jgao54 jgao54 marked this pull request as ready for review January 30, 2024 19:08
jgao54
jgao54 commented Jan 30, 2024
View reviewed changes
package.json
"name": "@figma/nodegit",
"description": "Node.js libgit2 asynchronous native bindings",
"version": "0.28.0-figma.3",
"version": "0.28.0-figma.5",
Copy link
Author

@jgao54 jgao54 Jan 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumped to v5 because we have v4 in s3 for some reason

@jgao54 jgao54 force-pushed the joygao/arm64-support branch from 3d47ec0 to d1ec05e Compare January 30, 2024 19:40
@jfirebaugh
Copy link
Member

Feel free to drop node 16 support too.

@jgao54 jgao54 force-pushed the joygao/arm64-support branch from d1ec05e to 123d895 Compare January 30, 2024 20:54
@jgao54 Graphite App
Copy link
Author

jgao54 commented Jan 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jgao54 and the rest of your teammates on Graphite Graphite

@jgao54 jgao54 merged commit df52afb into figma Jan 30, 2024
@samsternatretool
Copy link

@jgao54 looks like Linux ARM support was removed ... do you know why? We (Retool) would love to have it added back.

This was referenced Apr 15, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgao54 @jfirebaugh @samsternatretool