chore: fix install script for Windows #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleskac-figma
commented
Jun 30, 2025
Comment on lines
+29
to
+35
| const gypPath = path.join(__dirname, "..", "node_modules", "node-gyp", "bin", "node-gyp.js"); | ||
| var spawnedNodePreGyp = spawn(nodePreGyp, args, { | ||
| env: Object.assign({}, process.env, { | ||
| npm_config_node_gyp: path.join(__dirname, "..", "node_modules", | ||
| "node-gyp", "bin", "node-gyp.js") | ||
| }) | ||
| env: { | ||
| ...process.env, | ||
| npm_config_node_gyp: gypPath | ||
| }, | ||
| shell: process.platform === "win32" |
There was a problem hiding this comment.
This is nodegit@c12c5a4
Perhaps we could also just pull in all 70 commits from nodegit/nodegit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
install.jsfor Windows users.shell:trueis necessary forspawning due to https://nodejs.org/en/blog/vulnerability/april-2024-security-releases-2process.exit()must take an integer, not an error objectThis is a nice-to-have since likely
pnpm installdidn't work on Windows in the first place.EDIT: It actually seems this was partially upstreamed in nodegit@c12c5a4
Test Plan
Vibes right now.... would love to know how to test this out