Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add node 18 support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2023
Merged

add node 18 support #3

merged 4 commits into from
Apr 17, 2023

Conversation

@jgao54
Copy link

@jgao54 jgao54 commented Apr 14, 2023 •
edited
Loading

linux/macos nodegit 0.28.0-figma.3 binary have been created in s3, this PR:

  • bumps the version to fetch figma.3
  • upgrades ubuntu to 20.04 (ubuntu:16.04 fails with glibc version incompatibility)
  • allows npm set unsafe-perm true to fail (node 18 no longer supports it)
  • skips git clone test (this change is copied over from upstream)
  • updates statistics test (printed values from console.log and just updated them to make test pass. these values diverge from upstream's master, so i suspect is a recent change)

@jgao54 jgao54 closed this Apr 14, 2023
@jgao54 jgao54 reopened this Apr 14, 2023
@jgao54 jgao54 force-pushed the joygao/support-node-18-test branch from 99d0138 to 6a51bd7 Compare April 14, 2023 23:30
@jgao54 jgao54 changed the title test add node 18 support Apr 14, 2023
@jgao54 jgao54 force-pushed the joygao/support-node-18-test branch from 6a51bd7 to 67996cc Compare April 14, 2023 23:44
@jgao54 jgao54 force-pushed the joygao/support-node-18-test branch from 67996cc to 7b12381 Compare April 14, 2023 23:59
@jgao54 jgao54 marked this pull request as ready for review April 15, 2023 00:08
@jgao54 jgao54 requested a review from jfirebaugh April 15, 2023 00:09
@jgao54 jgao54 merged commit 33994cf into figma Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgao54 @jfirebaugh