Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wddcheng
Copy link
Contributor

@wddcheng wddcheng commented Mar 8, 2022

No description provided.

bkleyn and others added 14 commits February 24, 2022 18:13
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
# Conflicts:
#	mabwiser/base_mab.py
#	mabwiser/mab.py
#	tests/test_nearest.py
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
bkleyn
bkleyn previously approved these changes Mar 9, 2022
Copy link
Contributor

@bkleyn bkleyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, so I'm approving.

I'll let others chime in if there are remaining questions/comments.

bkleyn
bkleyn previously approved these changes Mar 9, 2022
skadio
skadio previously approved these changes Mar 9, 2022
Copy link
Contributor

@skadio skadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wddcheng !!

Signed-off-by: Du Cheng <[email protected]>
@wddcheng wddcheng dismissed stale reviews from skadio and bkleyn via 8f98e9a March 9, 2022 18:58
wddcheng and others added 6 commits March 9, 2022 14:11
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
@bkleyn bkleyn merged commit e03d242 into master Mar 9, 2022
@bkleyn bkleyn deleted the feature/lingreedy branch March 9, 2022 23:13
class LinGreedy(NamedTuple):
"""LinGreedy Learning Policy.
This policy trains a ridge regression for each arm.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ridge regression 'model'?

arm_to_scaler: Dict[Arm, Callable]
Standardize context features by arm.
Dictionary mapping each arm to a scaler object. It is assumed
that the scaler objects are already fit and will only be used

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'fitted'?


class LinGreedyTest(BaseTest):

def test_epsilon_zero(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see so many new unit tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants