-
Notifications
You must be signed in to change notification settings - Fork 46
Feature/lingreedy #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
# Conflicts: # mabwiser/base_mab.py # mabwiser/mab.py # tests/test_nearest.py
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Kleynhans, Bernard <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, so I'm approving.
I'll let others chime in if there are remaining questions/comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wddcheng !!
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
Signed-off-by: Du Cheng <[email protected]>
| class LinGreedy(NamedTuple): | ||
| """LinGreedy Learning Policy. | ||
| This policy trains a ridge regression for each arm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ridge regression 'model'?
| arm_to_scaler: Dict[Arm, Callable] | ||
| Standardize context features by arm. | ||
| Dictionary mapping each arm to a scaler object. It is assumed | ||
| that the scaler objects are already fit and will only be used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'fitted'?
|
|
||
| class LinGreedyTest(BaseTest): | ||
|
|
||
| def test_epsilon_zero(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see so many new unit tests!
No description provided.