fixes issue #667 #678
fixes issue #667 #678
Conversation
…nst/let AND strict mode
…nst/let AND strict mode
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 86.71% 86.63% -0.08%
==========================================
Files 16 16
Lines 1746 1736 -10
==========================================
- Hits 1514 1504 -10
Misses 232 232
Continue to review full report at Codecov.
|
vlogozzo
left a comment
There was a problem hiding this comment.
many changes can be const instead of let, review the inline comments
tests/spec/fs.write.spec.js
Outdated
|
|
||
| it('should be a function', function() { | ||
| var fs = util.fs(); | ||
| let fs = util.fs(); |
There was a problem hiding this comment.
fs can be const as it isnt changed in this scope
| let fs = util.fs(); | |
| const fs = util.fs(); |
tests/spec/fs.write.spec.js
Outdated
| var fs = util.fs(); | ||
| var fn = () => fs.writeFile(undefined, 'data'); | ||
| let fs = util.fs(); | ||
| let fn = () => fs.writeFile(undefined, 'data'); |
There was a problem hiding this comment.
fn can be const as well
| let fn = () => fs.writeFile(undefined, 'data'); | |
| const fn = () => fs.writeFile(undefined, 'data'); |
tests/spec/fs.write.spec.js
Outdated
| var fs = util.fs(); | ||
| var buffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); | ||
| let fs = util.fs(); | ||
| let buffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); |
There was a problem hiding this comment.
buffer is just passed into a function it can be const
| let buffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); | |
| constt buffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); |
humphd
left a comment
There was a problem hiding this comment.
I agree with the other review comments here, please make the updates.
Also, please back-out your changes to package-lock.json:
git checkout master package-lock-json
Then you can commit and push that to this branch, and it won't include this file. It's not related to your changes, so doesn't belong in this PR.
tests/spec/fs.write.spec.js
Outdated
| it('should error if file path is undefined', function() { | ||
| var fs = util.fs(); | ||
| var fn = () => fs.writeFile(undefined, 'data'); | ||
| let fs = util.fs(); |
There was a problem hiding this comment.
const here, since fs won't change
tests/spec/fs.write.spec.js
Outdated
| it('should write data to a file', function(done) { | ||
| var fs = util.fs(); | ||
| var buffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); | ||
| let fs = util.fs(); |
tests/spec/fs.write.spec.js
Outdated
| var fs = util.fs(); | ||
| var buffer = Buffer.from([1, 2, 3, 4, 5, 6, 7, 8]); | ||
| var _result = 0; | ||
| let fs = util.fs(); |
humphd
left a comment
There was a problem hiding this comment.
A couple of things you can change to const, and this is ready to go.
Update code in tests/some/fs.write.spec.js to use const/let AND strict mode