fixed Issue-689 indexedDB.js #700
Conversation
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 16 16
Lines 1746 1746
=======================================
Hits 1514 1514
Misses 232 232
Continue to review full report at Codecov.
|
humphd
left a comment
There was a problem hiding this comment.
I notice you updated some dependency versions in package.json. That's a good idea, but not in this bug. We tend to try and isolate changes from one another, and use a bug-per-fix. It makes it easier to track changes over time that way, and figure out where something went wrong when things break.
Can you unto these changes?
git checkout master package*
This will overwrite the files with what's on master. You can create a new branch and update these if you want in a new PR:
git checkout -b update-deps master
npm update
|
I updated my repo reverting the dependency changes, I saw that the pull request has my commit in it, are you notified when I do this, or should I leave a comment as well saying the changes have been made?
…________________________________
From: David Humphrey <[email protected]>
Sent: Thursday, January 31, 2019 3:17:24 PM
To: filerjs/filer
Cc: Vincent Logozzo; Author
Subject: Re: [filerjs/filer] fixed Issue-689 indexedDB.js (#700)
@humphd requested changes on this pull request.
I notice you updated some dependency versions in package.json. That's a good idea, but not in this bug. We tend to try and isolate changes from one another, and use a bug-per-fix. It makes it easier to track changes over time that way, and figure out where something went wrong when things break.
Can you unto these changes?
git checkout master package*
This will overwrite the files with what's on master. You can create a new branch and update these if you want in a new PR:
git checkout -b update-deps master
npm update
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#700 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AjOkZooCXXHreNghev2Tszo0nUBpSUEmks5vI09UgaJpZM4aYoZ8>.
|
I've made some changes to the indexedDB.js to use let and const on its local values