Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@oleksii-polovyi
Copy link
Contributor

@oleksii-polovyi oleksii-polovyi commented Jan 30, 2019

  • Invoked a strict mode
  • Refactored the code to use let and const instead of var

@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #722 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...a5f4912. Read the comment docs.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this is great.

const fs = util.fs();
expect(fs.promises.mkdir('/tmp')).to.be.a('promise');
});
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tip: it's a good idea to always include a newline at the end of all your files (I know this isn't your mistake, it was already like this). We do this, and GitHub shows its absence, because we want to avoid having concatenated files break when the end of one file and the start of another get joined. Just a tip for next time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will do.

@humphd humphd merged commit 317cee5 into filerjs:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants