fix var to const #723
fix var to const #723
Conversation
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=======================================
Coverage 86.71% 86.71%
=======================================
Files 16 16
Lines 1746 1746
=======================================
Hits 1514 1514
Misses 232 232Continue to review full report at Codecov.
|
jatinkumarg
left a comment
There was a problem hiding this comment.
Great work, you can also add 'use strict' at the top of the page.
|
Looks good. As stated, 'use strict' can be added for strict mode. |
humphd
left a comment
There was a problem hiding this comment.
This looks really good. I also agree with both your reviewers that you need to add 'use strict; to the top of the file. Please do that, then git add, git commit, and git push again to this same branch. It will get added. Let me know when that's done and I'll re-review.
|
@QingLianLiu how is this coming? |
Fix var into const