Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nkolba
Copy link
Contributor

@nkolba nkolba commented Dec 9, 2019

Added language in response to issue 132. Note: I made the window.fdc3 global a "SHOULD" rather than a "MUST", based on the thinking that while this is a strong best practice, the absence of window.fdc3 would not break any core FDC3 functionality if not done (only make life a bit harder for application developers). Please see http://www.rfc-editor.org/rfc/rfc2119.txt . for more reading on MUST v SHOULD

Copy link
Contributor

@rikoe rikoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SHOULD is fine - some implementations may decide not to use the mechanism, with an impact on compatibility they may choose to accept.

Should we wait until the next API WG meeting to merge?

@rikoe rikoe added the api FDC3 API Working Group label Jan 8, 2020
@nkolba nkolba merged commit 2683a0d into finos:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api FDC3 API Working Group cla-present

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants