Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add (manually created) enums for intents and context types. #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2020
Merged

Add (manually created) enums for intents and context types. #264

merged 1 commit into from
Oct 16, 2020

Conversation

@mattjamieson
Copy link
Contributor

Per #261, adding manually created enums for intents and context types:

let instrumentContext: Instrument = {
  type: ContextTypes.Instrument,
  id: {
    ticker: "GBPUSD"
  }
};

fdc3.raiseIntent(Intents.ViewChart, instrumentContext);

Additional PR to follow to improve typegen to use enum types etc. Will be for 1.2 as it necessitates changes to the schema files.

@finos-cla-bot
Copy link

finos-cla-bot bot commented Oct 15, 2020

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement.

Having reviewed our contributor list, we require a CLA for the following people : (@mattjamieson).

If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email [email protected] with your questions.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request.

cc @finos-admin

@mattjamieson mattjamieson marked this pull request as draft October 15, 2020 11:01
@mattjamieson mattjamieson marked this pull request as ready for review October 15, 2020 11:02
@mattjamieson
Copy link
Contributor Author

@finos-cla-bot[bot] check

1 similar comment
@maoo
Copy link
Member

maoo commented Oct 16, 2020

@finos-cla-bot[bot] check

@maoo
Copy link
Member

maoo commented Oct 16, 2020

@cla-bot[bot] check

@finos-cla-bot
Copy link

finos-cla-bot bot commented Oct 16, 2020

The cla-bot has been summoned, and re-checked this pull request!

@rikoe rikoe merged commit ea58aa4 into finos:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rikoe rikoe rikoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-present

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattjamieson @maoo @rikoe