fix: use a public user object to prevent passwords and other secrets … #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent penetration test identified that the
/api/v1/userendpoint exposes sensitive internal user data, including:Root Cause
The API response was serializing raw user objects directly from the database, without filtering or transforming the fields. A previous fix attempt (#741) tried to exclude the password field using:
collection.find(query, { password: 0 }).toArray();However, this projection syntax is no longer valid in MongoDB Node.js Driver v5, where the second argument to
find()must be an explicit FindOptions object. As a result, the fix was ineffective, and sensitive fields continued to be returned.Fix
This PR addresses the issue on two levels: