refactor: migrate configuration system from JSON Schema to QuickType #1140
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 83.44% 83.67% +0.23%
==========================================
Files 66 67 +1
Lines 2790 2886 +96
Branches 332 365 +33
==========================================
+ Hits 2328 2415 +87
+ Misses 413 410 -3
- Partials 49 61 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Given that @JamieSlome was covered by the Citi CCLA at the time the commits were made we can ignore the EasyCLA bot in this particular case. A @finos/git-proxy-maintainers should be able to force merge this PR. Please email [email protected] with any questions or concerns. |
|
@kriswest Would be great if you could take another look at this - I think it fixes a lot of typing issues with the config. |
|
Forgot to say - lets have this in v2 @finos/fdc3-maintainers ! |
There was a problem hiding this comment.
LGTM! As @finos-admin mentioned, I'll be ignoring the EasyCLA bot warning for this PR.
|
@TheJuanAndOnly99 @finos-admin This is ready to merge! 🚀 |
Replace JSON-Schema for config validation and default injection
Add typed
configexport,loadConfig(),validate()andsetConfigFile()Update
index.tsto use the new loader and pass the validated config.Note: Restored from deleted fork
This PR recreates the original PR #998, which was automatically closed due to accidental fork deletion.
** For discussions and reviews:** See the original PR #998
All commits are identical to the original with preserved git history.