refactor(ts): refactor proxy to TS
#960
Conversation
…-refactor-db-module
There was a problem hiding this comment.
Wonderful PR - thank you @jescalada for picking this up! This has been a thorn in the side of this project for awhile now and very pleased to see typescript finally land. Appreciate this contribution.
I've left a few areas where I think more types can be added as well as a minor dependency change.
|
@JamieSlome we will need to contact an org admin to modify the required PR status check. It is explicitly set to |
|
Thanks for the review @coopernetes! I originally bumped the Node CI to 22 due to some ESM errors, but I managed to fix them. That said, there's a |
390de82 to
90a8cab
Compare
|
Hi @coopernetes, I just fixed up those lines you mentioned, and did some manual testing to make sure the flow still works as expected. I'm a bit confused about this part on -const exec = async (req: any, action: Action): Promise<Action> => {
+async function exec(req: any, action: Action): Promise<Action> {Thanks! |
That's just a style preference. I'm not against the use of arrow functions so long as we have clear typing on the function arguments & return type. |
There was a problem hiding this comment.
I will suggest we add an eslint rule to warn on those any usages so we can clean them up over time. Otherwise, LGTM.
The plugin code could use more strict typing but since it's doing dynamic module loading, this is a good way forward for the rest of the proxy server code.
|
@jescalada Can you resolve the conflicts and then this can be merged? thanks! |
Head branch was pushed to by a user without write access
|
@coopernetes Thank you again for the review! The merge conflicts required me to refactor one more file. I didn't manually test the changes, but the unit tests seem to pass. Just to remind you, #805 fixes the proxy tests for more code coverage (quite crucial since the core proxy logic is stubbed!). Maybe we could ping the author to remind them to complete the CLA? Thanks! |
|
Great job @jescalada and @coopernetes for the review ❤️ I assume this is at least a minor bump, potentially even major? Let me know and I'll schedule a new release 🚀 |
Fixes #965.
This PR refactors most of the proxy logic to TS. It builds on the
dbandconfigrefactor PRs.The tests are passing, but they do not cover the push/pull processor functions (because the logic is stubbed). There's a fix for this in #805, which might be worth looking at!