Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sth0
Copy link
Contributor

@sth0 sth0 commented Apr 1, 2025

nodeenv is a pre-req for pre-commit. This version has the tests commented out since I think they need two more new packages and not sure how many more after that. Builds and installs with the -mv options in fink. See PR #1225
Uses modern bootstrap module so limited to python >= 3.8

Copy link
Member

@nieder nieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds. I enabled tests to see what happens, and two tests fail, looking for node and/or nodejs, which is not surprising since this is for creating node environments:

E           subprocess.CalledProcessError: Command '('coverage', 'run', '-p', '-m', 'nodeenv', '-n', 'system', '/private/tmp/pytest-of-fink-bld/pytest-0/test_smoke_n_system_special_ch0/nenv (production env)')' returned non-zero exit status 1.

/sw/lib/python3.8/subprocess.py:364: CalledProcessError
-------------------------------------------------------------------------------- Captured stderr call --------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/sw/build.build/nodeenv-py38-1.9.1-1/nodeenv-1.9.1/nodeenv.py", line 1548, in <module>
    main()
  File "/sw/build.build/nodeenv-py38-1.9.1-1/nodeenv-1.9.1/nodeenv.py", line 1130, in main
    create_environment(env_dir, args)
  File "/sw/build.build/nodeenv-py38-1.9.1-1/nodeenv-1.9.1/nodeenv.py", line 1014, in create_environment
    install_activate(env_dir, args)
  File "/sw/build.build/nodeenv-py38-1.9.1-1/nodeenv-1.9.1/nodeenv.py", line 946, in install_activate
    assert shim_node, "Did not find nodejs or node system executable"
AssertionError: Did not find nodejs or node system executable

...
dyld: cannot load 'node' (load command 0x80000034 is unknown)
sh: line 1: 84409 Abort trap: 6           node --version

So node should be at least included as a TestDepends once you activate tests, and should also be a RuntimeDepends or Depends.

coverage-py also would need to be added to TestDepends once those are enabled.

@sth0
Copy link
Contributor Author

sth0 commented May 10, 2025

I left the testing turned off since the source for nodejs was not available. It searched several of the mirrors and the source but no luck. If the distfiles.finkmirrors gets fixed then I will revisit it. This just seemed like an endless chain of depends that was dragging me further from getting lftp fixed and used as part of duplicity which is my original goal.
"When you are up to your knees in alligators, it is hard to remember that your original intent was to drain the swamp"

@sth0
Copy link
Contributor Author

sth0 commented May 10, 2025

Also, if I do find the source code for nodejs, it doesn't build with an error. The nodejs is version 12 and current version is 24 and upstream is not interested in fixing it for a valid reason.
nodejs/node#54187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants