Remove scanning for protected DLL. Remove Mono.Cecil #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on Mono.Cecil and eliminates the need to scan for protected DLLs by updating the validation approach to use build assets instead. The changes simplify the license validation process and reduce external dependencies.
Key changes:
- Removed Mono.Cecil dependency and assembly processing capabilities
- Eliminated
PackageReferencesandResolvedCompileFileDefinitionstask parameters - Removed
AssemblyUtilsclass that handled assembly reading
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ValidateLicenseTask.cs | Removed task parameters and protected DLL scanning logic |
| AssemblyUtils.cs | Completely removed assembly processing utilities |
| NuSeal.csproj | Removed Mono.Cecil package reference and related build exclusions |
| Directory.Packages.props | Removed Mono.Cecil version specification |
| Assets.cs | Updated generated targets to exclude removed task parameters |
| ValidateLicenseTaskTests.cs | Simplified tests by removing assembly creation and parameter setup |
| AssemblyUtils_ExtractPemsTests.cs | Completely removed test file for deleted functionality |
| GenerateConsumerAssetsTaskTests.cs | Updated expected output to match new task parameters |
| AssetsTests.cs | Updated expected output to match new task parameters |
| NuSeal.props | Removed commented debugging code |
| NuSeal.Tests.csproj | Removed Mono.Cecil test dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #27
PackageReferencesandResolvedCompileFileDefinitionstask parameters.Mono.CecilAssemblyUtils. We no longer reading or processing assemblies.