Handle environments with multiple NuSeal versions #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Introduce version-specific MSBuild task class name to allow coexistence of multiple NuSeal versions in the same build environment. Key change is renaming ValidateLicenseTask to ValidateLicenseTask_0_4_0 and updating asset generation, tests, and task registration accordingly.
- Rename public task class to a versioned identifier
- Update assets/task registration and tests to reference the new versioned task name
- Minor cleanup of unused usings
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/NuSeal.Tests/ValidateLicenseTaskTests_0_4_0.cs | Renames test class and task usages to versioned name |
| tests/NuSeal.Tests/GlobalUsings.cs | Removes unused using and reorders Xunit using |
| tests/NuSeal.Tests/GenerateConsumerAssetsTaskTests.cs | Updates MSBuild XML task references to versioned task name |
| tests/NuSeal.Tests/AssetsTests.cs | Updates MSBuild XML task references to versioned task name |
| src/NuSeal/Tasks/ValidateLicenseTask_0_4_0.cs | Renames public task class and adjusts log message |
| src/NuSeal/Tasks/GenerateConsumerAssetsTask.cs | Removes an unused using |
| src/NuSeal/Assets.cs | Updates TASK_NAME constant to versioned task class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
I'm in doubt whether this is a good idea or not, but I have no other solution. There is no way we can use arbitrary names for a task in
UsingTaskand make it unique per version.