[Merged by Bors] - fix: make animation end frame index inclusive#536
Closed
zicklag wants to merge 1 commit intofishfolk:mainfrom
Closed
[Merged by Bors] - fix: make animation end frame index inclusive#536zicklag wants to merge 1 commit intofishfolk:mainfrom
zicklag wants to merge 1 commit intofishfolk:mainfrom
Conversation
The animation system was looping through the frames, not including the end frame in the animation, which is unintuitive. This makes the animation system include the final frame.
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2022
The animation system was looping through the frames, not including the end frame in the animation, which is unintuitive. This makes the animation system include the final frame.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
zicklag
added a commit
to zicklag/jumpy
that referenced
this pull request
Jan 12, 2023
The animation system was looping through the frames, not including the end frame in the animation, which is unintuitive. This makes the animation system include the final frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animation system was looping through the frames, not including the end frame in the animation, which is unintuitive.
This makes the animation system include the final frame.