fix: fix crash when second player selects player in online match second.#836
Merged
zicklag merged 1 commit intofishfolk:mainfrom Jul 8, 2023
Merged
fix: fix crash when second player selects player in online match second.#836zicklag merged 1 commit intofishfolk:mainfrom
zicklag merged 1 commit intofishfolk:mainfrom
Conversation
There's an unexpected `ConfirmSelection(true)` network message sent to player to, along with a mis-placed assertion that assumed the message was a map selection message. This fixes the assertion, but leaves the warning about the unexpected network message un-addressed, except for a TODO comment explaining what's happening. Fixes: fishfolk#834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's an unexpected
ConfirmSelection(true)network message sent to player 2, along with a mis-placed assertion that assumed the message was a map selection message.This fixes the assertion, but leaves the warning about the unexpected network message un-addressed, except for a TODO comment explaining what's happening.
Fixes: #834