fix: Fix puffin profiler not showing anything#832
Merged
zicklag merged 3 commits intofishfolk:mainfrom Jul 8, 2023
Merged
Conversation
Puffin is 0.16 while puffin_egui is 0.21, these are out of step. Upgrading puffin_egui to 0.22 is not an option until bevy_egui has a relase available on egui 0.22, currently 0.21.
Collaborator
Author
|
After another look, not 100% this is fixed, don't seem to be many scopes at all in profiler, gonna poke around. |
Collaborator
Author
|
Seeing scopes now - realized most of them were in jumpy_core and did not update the version there. |
Member
|
Awesome, thanks for looking into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #831, we are using incompatible puffin / puffin-egui versions.
We updated puffin to 0.16, but did not upgrade puffin_egui to 0.22 (these versions were bumped together). We likely did not upgrade puffin_egui because this causes a compilation error, as bevy_egui is still using dep egui 0.21 (while puffin_egui is at 0.22), types mismatch.
Downgrading puffin to 0.15 fixes it. Can upgrade puffin crates once bevy_egui has a release with egui 0.22.
Additionally, fixes a panic opening profiler in wasm due to missing web feature.