Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

valery-barysok
Copy link
Contributor

It fixes the import issue described in #443

@valery-barysok
Copy link
Contributor Author

@hiranya911, I added test cases and created PR to dev branch.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @valery-barysok. This looks pretty good. Just one comment for your consideration.

@hiranya911 hiranya911 changed the title Fix incorrect import of partial user metadata. fix(auth): Fix incorrect import of partial user metadata. May 26, 2021
@hiranya911
Copy link
Contributor

CI has detected some code formatting issues. Please run gofmt and push the changes.

@valery-barysok
Copy link
Contributor Author

@hiranya911, I resolved all comments. Could you please take a look?

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@hiranya911 hiranya911 self-assigned this May 27, 2021
@hiranya911 hiranya911 merged commit 6c73cd6 into firebase:dev May 27, 2021
@valery-barysok valery-barysok deleted the dev branch May 27, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants