Mila/multi db #1321
Merged
Mila/multi db #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-andersen
requested changes
May 15, 2023
Co-authored-by: Tom Andersen <[email protected]>
…pp-sdk into mila/MultiDB
wu-hui
reviewed
May 18, 2023
firestore/integration_test_internal/src/util/locate_emulator.cc
Outdated
Show resolved
Hide resolved
| * the given database ID. | ||
| */ | ||
| static Firestore* GetInstance(::firebase::App* app, | ||
| const char* db_name, |
There was a problem hiding this comment.
I dont have the API proposal at hand, but what is the reason to use const char* here instead of a const std::string& ?
There was a problem hiding this comment.
In the original API proposal , it was const std::string&, and later requested to be changed to const char*. I am not sure why.
There was a problem hiding this comment.
OK, at least we should find out why. I suppose there is a reason they asked for this.
milaGGL
commented
May 19, 2023
tom-andersen
approved these changes
May 19, 2023
❌ Integration test FAILEDRequested by @milaGGL on commit 35f554b
Add flaky tests to go/fpl-cpp-flake-tracker |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiDB support.
Ported from:
TODO:
Firestore::GetInstancepublic interface to accept dynamic database namestd::pair<App*, std::string>as key instead ofApp*, to identify DBs in the same app while creating and deleting firestore instances.TestFirestoreWithDatabaseIdandIsUsingFirestoreEmulatortest helper method- New
GetInstancemethod call verification- Instances' equality check
- Can create & terminate multiple Firestore instances
- Can create and fetch documents from different Firestore instances offline and online