feat: allow amending context in Init #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, thanks for the PR! |
Contributor
Author
|
Currently, the proxy handler struct is initialized once for the lifetime of the proxy server. However, I aim to associate state on a per-request basis. Storing such data within the handler struct necessitates a unique, hashable key for each request. Regrettably, within the current implementation, I am unaware of any suitable mechanism to differentiate between requests. |
Owner
|
Thanks! Released v0.4.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing Contextual Awareness in ProxyHandler
While this library performs admirably, a critical aspect is lacking in my view: context between handler calls.
In my application, it's imperative to discern which connection is presently managed in each call. Although one could resort to
context.AfterFunc(ctx, fun)withinProxyHandler.Init, it proves impractical and undermines the purpose of theProxyHandler.Closefunction. This PR introduces the capability to enrich the context with pertinent values, enabling the tracking of requests throughout their lifecycle and facilitating appropriate actions at each stage.I trust you find these adjustments beneficial. Keep up the exceptional work! 😊