Update int_github__issue_joined.sql #31
Conversation
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
Thanks so much for opening this PR @jackiexsun! 💯 I am so happy you are contributing to our packages!
I just tested your proposed changes locally and was having trouble with the query compiling properly. I added a suggestion in line that you can try on your end. It worked for the sample set I just used.
If you want to test these changes yourself, you can actually install your forked branch in place of the dbt hub package version! You can do that by removing the fivetran/github package dependency in the packages.yml file and using the below instead:
packages:
- git: https://github.com/jackiexsun/dbt_github.git
revision: patch-1
warn-unpinned: falseThis will allow you to install your forked version on dbt deps and run your code in place of the package code. Feel free to test this out and apply the suggestion I made. Let me know if you have any questions!
Also, FYI since we are using dbt v0.20.2 internally we will use a similar git branch dependency style if you want to integrate these changes ASAP since the latest version of the package only supports dbt >= v1.0.0
|
@fivetran-joemarkiewicz thanks for the review! i converted it to your suggestion and ran the model locally, and it compiled and produced the right url links. |
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
Thanks again so much @jackiexsun for this contribution! The changes look great to me.
Also, I added a few updates to include the version update and also some CHANGELOG additions. All looks good to merge to me!
Pull Request
Are you a current Fivetran customer?
I work at Fivetran :)
What change(s) does this PR introduce?
Fixes this #30
Did you update the CHANGELOG?
How do I do that?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
How do I do that?
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
First i ran
dbt run -m +int_github__issue_joinedand then I randbt run -m github__issuesand I examined the output.Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🌮
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.