Feature/databricks compat #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-jamie
approved these changes
Nov 9, 2022
Contributor
fivetran-jamie
left a comment
There was a problem hiding this comment.
looks good -- the most imperative comment is regarding adding spark_utils to the README dependency section, but i'll go ahead and approve
| **How did you test the PR changes?** | ||
| <!--- Proof of testing is required in order for the PR to be approved. --> | ||
| <!--- To check a box, remove the space and insert an x in the box (eg. [x] CircleCi). --> | ||
| <!--- To check a box, remove the space and insert an x in the box (eg. [x] Buildkite). --> |
Contributor
There was a problem hiding this comment.
same as src, wanna remove line 1?
| ```yml | ||
| dispatch: | ||
| - macro_namespace: dbt_utils | ||
| search_order: ['spark_utils', 'dbt_utils'] |
Contributor
There was a problem hiding this comment.
should add this to the package-dependency matrix
packages.yml
Outdated
| # Update before merge | ||
| - git: https://github.com/fivetran/dbt_github_source.git | ||
| revision: MagicBot/dbt-utils-cross-db-migration | ||
| revision: feature/databricks-compat |
Contributor
There was a problem hiding this comment.
obligatory reminder to update though doesn't matter too much in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Are you a current Fivetran customer?
Fivetran Employee
What change(s) does this PR introduce?
Adding databricks compatibility
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Rolling out with migrations
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.