Non null pipe deserialization #322
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipeMessagemessage deserialization has until now worked by callingJsonSerializer.Deserialize<T>(string)directly, which can returnnullin the case that the incoming string is the json literal "null". This has two unfortunate consequences:!, or else the nullability could spread from there.JsonSerializer.Deserialize<T>(string)need to be reviewed, whether relevant to these pipe messages or not, in order to instill the confidence to declare!accurately. In fact, all of the pipe messages deserialized come from sources that would not be null during serialization, but it's been a nontrivial analysis each time.This PR formalizes the path to serialize and deserialize
PipeMessagetypes, giving the opportunity to check for null and fail fast, allowing thisDeserializemethod to be declared as returning a non-null message, letting call sites omit the risky!assertion.