Thanks to visit codestin.com
Credit goes to github.com

Skip to content

error when variable name starts with 0..9 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cre4ture wants to merge 1 commit into from
Closed

error when variable name starts with 0..9 #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ fn parse_variable(source: &[u8], finger: usize) -> Result<Variable, Error> {
if source[finger + 1] == b'{' {
parse_braced_variable(source, finger)
} else {
let name_end = match source[finger + 1..].iter().position(|&c| !c.is_ascii_alphanumeric() && c != b'_') {
let name_start = finger + 1;
check_fist_char_of_variable_name(source, name_start)?;
let name_end = match source[name_start..].iter().position(|&c| !c.is_ascii_alphanumeric() && c != b'_') {
Some(0) => return Err(error::MissingVariableName {
position: finger,
len: 1,
Expand All @@ -197,6 +199,21 @@ fn parse_variable(source: &[u8], finger: usize) -> Result<Variable, Error> {
}
}

fn check_fist_char_of_variable_name(source: &[u8], name_start: usize) -> Result<(), Error> {
let first_char = source[name_start];
if first_char.is_ascii_digit() {
return Err(error::Error::UnexpectedCharacter(error::UnexpectedCharacter{
position: name_start,
character: error::CharOrByte::Byte(first_char),
expected: error::ExpectedCharacter {
message: "variable name must not start with 0..9"
}
}))
}

Ok(())
}

/// Parse a braced variable in the form of "${name[:default]} from source at the given position.
///
/// The finger must be the position of the dollar sign in the source.
Expand All @@ -209,6 +226,8 @@ fn parse_braced_variable(source: &[u8], finger: usize) -> Result<Variable, Error
}.into())
}

check_fist_char_of_variable_name(source, name_start)?;

// Get the first sequence of alphanumeric characters and underscores for the variable name.
let name_end = match source[name_start..].iter().position(|&c| !c.is_ascii_alphanumeric() && c != b'_') {
Some(0) => return Err(error::MissingVariableName {
Expand Down