Merged
Conversation
|
| Name | fkYAML_coverage.pr421.zip |
|---|---|
| ID | 2172937302 |
| URL | https://github.com/fktn-k/fkYAML/actions/runs/11784963384/artifacts/2172937302 |
419254a to
6815f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added support of much more STL container types in
basic_node::get_value()API.For details, please visit the documentation for the API.
Moreover, the API now accepts basic_node template instance types as its return type to allow conversions to container types whose element type is a basic_node template instance type, e.g.,
std::array<fkyaml::node, 3>orstd::unordered_map<fkyaml::node, fkyaml::node>.When this library is compiled with C++17 or greater,
std::optionalcan be the return type which holds some converted value on success orstd::nulloptotherwise.Types which were convertible from nodes should still be convertible in the same way.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdefs or other means.