Clarify type restrictions of get_value() & get_value_ref() APIs#424
Merged
Clarify type restrictions of get_value() & get_value_ref() APIs#424
Conversation
|
| Name | fkYAML_coverage.pr424.zip |
|---|---|
| ID | 2196006579 |
| URL | https://github.com/fktn-k/fkYAML/actions/runs/11867168871/artifacts/2196006579 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although get_value() calls with a reference, pointer, or C-style array type are not supported, but actual attempts of such calls emit user-unfriendly compile error messages.
So, in this PR,
static_asserts have been added to detect those types and emit an error message which clearly states they are unsupported.The documentation pages for get_value() and get_value_ref() APIs have also been updated to clarify type restrictions.
Pull Request Checklist
Read the CONTRIBUTING.md file for detailed information.
Please don't
#ifdefs or other means.