Conversation
…moved batch loss average). running version, ready for PR.
…nce_labeling_refactoring � Conflicts: � flair/models/sequence_tagger_model.py
|
@whoisjones is there any status update on this? |
|
@helpmefindaname currently shifting the sequence labeler below the DefaultClassifier. We still need a parser for previous models, so it still takes some days, but feel free to contribute on this branch. |
…nce_labeling_refactoring
There was a problem hiding this comment.
why these relative module paths? why not flair.datasets?
Sequence tagger speedups
There was a problem hiding this comment.
the if check souldn't be required, as sentences is always of type List[Sentence] if typing isn't violated
There was a problem hiding this comment.
as yes, right! I'll push a correction, thanks!
There was a problem hiding this comment.
The Union doesn't make sense, as sentences is of type List[Sentence] we will always have reordered_sentences: List[Sentence] also, I think mypy is able to auto-infer the type of reordered_sentences so the typing might not be necessary
There was a problem hiding this comment.
also a good point, this is I think a leftover from times when str could also be passed to the predict function!
|
@whoisjones thanks a lot for improving this! |
Closes #2360.