Restructure Tokenizer and Splitter modules#3002
Merged
Conversation
Collaborator
Author
|
However, it doesn't really seem to make a difference in runtime. Tested with import timeit
t = timeit.Timer(setup='from flair.data import Sentence',
stmt='Sentence("a a a a a a a a a a ")')
print(t.timeit()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When initializing a
Sentenceobject, withuse_tokenizer=True(set by default), it triggered an import of theSegtokTokenizerin the Sentence constructor. According to this thread, there is a cost of re-importing modules and since we often create large numbers ofSentenceobjects, this is unnecessary overhead.This PR makes the import global. To do this, it splits up the
flair.tokenizationmodule into tokenization (for all tokenizers) and splitter (for all sentence splitters). This way, there is no longer an import offlair.datainflair.tokenization.