Merged
Conversation
alanakbik
reviewed
Dec 3, 2022
Comment on lines
+649
to
+651
| tokens.append(token) | ||
|
|
||
| sentence: Sentence = Sentence(text=tokens) |
Collaborator
There was a problem hiding this comment.
This looks much cleaner than creating an empty sentence and adding tokens. I wonder if this means we can retire the add_token method entirely in a separate PR?
Member
Author
There was a problem hiding this comment.
Looking at the usage after this PR, we still have the following usages:
- Tests, which can be rewritten
UniversalDependenciesDatasetwhich works the same way as the ColumnDataset worked before- Sentence - constructor, which I would prefer to keep.
We can surely make the add_token method private
Member
Author
There was a problem hiding this comment.
I added a proposal to this PR
alanakbik
reviewed
Dec 3, 2022
Comment on lines
+694
to
+698
| for comment_row in comment.split("\t"): | ||
| if "=" in comment_row: | ||
| key, value = comment_row.split("=", 2) | ||
| sentence.add_metadata(key, value) | ||
|
|
Collaborator
There was a problem hiding this comment.
Thanks for adding this, we really needed this feature in ColumnDataset :)
Collaborator
|
@helpmefindaname thanks for adding this and for the add_token modifications! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following features:
# id 2c8f5b49-4df5-44b5-8c2a-bdc340010ea3 domain=de-lownerwill add a metadatadomainwith the valuede-lowner. In general, this is about tab separated<key>=<value>patterns.