Thanks to visit codestin.com
Credit goes to github.com

Skip to content

drop python 3.8#3560

Merged
alanakbik merged 3 commits intomasterfrom
drop_python3.8
Nov 8, 2024
Merged

drop python 3.8#3560
alanakbik merged 3 commits intomasterfrom
drop_python3.8

Conversation

@helpmefindaname
Copy link
Member

@helpmefindaname helpmefindaname commented Oct 25, 2024

Since python3.8 is no longer supported, we can now drop it and use python3.9 features in our code, especially improving typing.

This pr does:

  • increase the minimum python version to 3.9 and uses it in gh-actions
  • update ruff to version 0.7 & fixes new linting errors
  • uses the python3.9 typing features
  • removes some methods that aren't used since longer
  • ensure that transformer embeddings will stay with the attention implementation that were saved, preventing precision issues after reloading.

@alanakbik alanakbik merged commit 7eb8533 into master Nov 8, 2024
@alanakbik alanakbik deleted the drop_python3.8 branch November 8, 2024 11:38
@alanakbik
Copy link
Collaborator

@helpmefindaname thanks a lot for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments