Add support for numeric map keys #269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
Hi Florian,
The test is here:
https://github.com/flosch/pongo2/pull/269/files#diff-60c354206e504d66cb5b2fab9b3bab7b8a9cb3067ee0a31d9ca3b3eb333cddabR31
Is this insufficient?
– Daniel
…On Fri, Dec 10, 2021 at 3:41 AM Florian Schlachter ***@***.***> wrote:
Please add some tests, thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#269 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEYSGIRVOJTNNVTHUJZEZ3UQHRQJANCNFSM5BHRTAIA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Author
|
@flosch Sorry to bother, could I please get some feedback on this PR? It seems straight-forward and has test coverage. If there's anything else I can do to unblock this, please let me know. Thank you for your time. |
Owner
|
Hi, this should be resolved by the introduced subscript syntax (#281): If not, feel free to re-open/answer again. Thanks! |
Author
|
Yes that looks good, I'll give that a shot! Thank you for your efforts on this library, I really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have data from an external source which contains map[string]interface{} instances with numeric keys:
I'm trying to access this map via this template
{{ mydict.0 }}as I would a regular map, but Pongo2 doesn't seem to allow this:This PR adds this capability.