Do not send count and offset params when requesting the entire object #5356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| offset: 2, | ||
| count: 4, | ||
| ); | ||
| expect(mapGrouping.isPartialObject, isTrue); |
Member
There was a problem hiding this comment.
instead of duplicating all the groups for childCount and isPartialObject, can we just make 'map instances', 'list instances' etc. top level groups for which we check the childCount and isPartialObject values?
also, should we check Set objects too?
Member
Author
There was a problem hiding this comment.
Good idea, refactored the test. Also added test cases for sets
Comment on lines
+70
to
+73
| buildListVariable(), | ||
| buildMapVariable(), | ||
| buildStringVariable('test str'), | ||
| buildBooleanVariable(true), |
Member
There was a problem hiding this comment.
can we add a Set variable in here too?
Member
Author
There was a problem hiding this comment.
Yes! Done. Refactored a little to avoid test case duplication with verifyGroupings method
kenzieschmoll
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5329
Previously, for objects where there was no explicitly set offset and childCount, we were sending
getObjectrequests withoffsetset to 0 andcountset to the length of the object (if it was aList,Map,RecordorSetinstance) or 0 if it wasn't.This was causing the following problem: if we missed any of the instance kinds that had a
length(for example, we were missingSetinstances), then we would send agetObjectrequest withcountequal to 0. The VM service would then correctly respond with an empty object.This PR does not include
offsetandcountparams ingetObjectrequests, unless we are explicitly requesting a partial object.