Do not await service extension call in the performance screen #9162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
May 1, 2025
| // upon connection. | ||
| unawaited( | ||
| serviceConnection.serviceManager | ||
| .callServiceExtensionOnMainIsolate( |
Contributor
There was a problem hiding this comment.
It might be worth auditing the locations where we invoke service extensions to make sure we're not awaiting responses anywhere that could possibly cause a hang.
This was referenced May 1, 2025
hrajwade96
pushed a commit
to hrajwade96/devtools
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes infinite spinner when Performance page is opened while connected to a paused Flutter app. Addresses hang issue described here: #6708 (comment)