Clean up abstract classes that only contain static methods #9170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
May 2, 2025
| /// A namespace for VM service related server request handlers. | ||
| @visibleForTesting | ||
| abstract class Handler { | ||
| extension VmServiceHandler on Never { |
Member
Author
There was a problem hiding this comment.
technically a breaking rename, but this is a visibleForTesting member so no changelog update / version bump required.
kenzieschmoll
commented
May 2, 2025
| required String vmServiceUriAsString, | ||
| required Uri vmServiceUri, | ||
| required bool connected, | ||
| // ignore: avoid-unused-parameters, false positive. |
Member
Author
There was a problem hiding this comment.
FYI @incendial, this parameter is used directly above on line 83.
Contributor
There was a problem hiding this comment.
Isn't this lint indicating that it isn't used inside this function? That seems correct.
We could mark it deprecated if we don't want to remove it?
Member
Author
There was a problem hiding this comment.
Ah... good point. Removed.
jakemac53
approved these changes
May 2, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 5, 2025
Note: `Handler` was removed from `devtools_server` in flutter/devtools#9170 Change-Id: Ic29658a1caece780a72125ca8ed040bbdc2405e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426540 Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Elliott Brooks <[email protected]> Reviewed-by: Kenzie Davisson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9169.