Avoid conflating concept of duration in TimeRange util class
#9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
568e85a to
eaaaf4e
Compare
eaaaf4e to
87e29cd
Compare
elliette
requested changes
Jul 23, 2025
Member
elliette
left a comment
There was a problem hiding this comment.
A couple comments but this looks good, thank you!
elliette
approved these changes
Jul 24, 2025
hrajwade96
pushed a commit
to hrajwade96/devtools
that referenced
this pull request
Sep 2, 2025
…er#9325) `TimeRange` represents the range between two `start` and `end` times marked in microseconds (so a duration). However, it stored `start` and `end` as `Duration` as well, resulting in the existence of three durations which was a bit confusing as I worked to understand code using `TimeRange`. Beyond that, `TimeRange` was not immutable so had a concept of being "well formed" (or having both a start and end), resulting in multiple checks for that state and many not-null assertion operations. To maintain the intermediate status and also reduce the necessity of the not-null assertions, split out the intermediate state to a new `TimeRangeBuilder` class with a `build` method that consolidates the not-null assertions to that singular function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeRangerepresents the range between twostartandendtimes marked in microseconds (so a duration). However, it storedstartandendasDurationas well, resulting in the existence of three durations which was a bit confusing as I worked to understand code usingTimeRange.Beyond that,
TimeRangewas not immutable so had a concept of being "well formed" (or having both a start and end), resulting in multiple checks for that state and many not-null assertion operations. To maintain the intermediate status and also reduce the necessity of the not-null assertions, split out the intermediate state to a newTimeRangeBuilderclass with abuildmethod that consolidates the not-null assertions to that singular function.