Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert PR #9372: Un-delete packages/devtools_shared/lib/src/test/chrome.dart #9409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

Revert PR #9372: Un-delete packages/devtools_shared/lib/src/test/chrome.dart #9409

merged 2 commits into from
Aug 22, 2025

Conversation

@elliette
Copy link
Member

@elliette elliette commented Aug 22, 2025

Reverts #9372

That change caused the following error when rolling DevTools into the Dart SDK:

Analyzing pkg...

  error - dds/test/devtools_server/instance_reuse_test.dart:73:30 - Undefined name 'Chrome'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
  error - dds/test/devtools_server/instance_reuse_test.dart:117:30 - Undefined name 'Chrome'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
  error - dds/test/devtools_server/server_connection_common.dart:85:28 - Undefined name 'Chrome'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
  error - dds/test/devtools_server/utils/server_driver.dart:93:9 - Undefined name 'useChromeHeadless'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier
  error - dds/test/devtools_server/utils/server_driver.dart:93:30 - Undefined name 'headlessModeIsSupported'. Try correcting the name to one that is defined, or defining the name. - undefined_identifier

5 issues found.

@elliette elliette requested a review from srawlins August 22, 2025 17:59
srawlins
srawlins approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment and the follow-up issue!

@elliette elliette added release-notes-not-required autosubmit Merge PR when tree becomes green via auto submit App labels Aug 22, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2025
@auto-submit
Copy link

auto-submit bot commented Aug 22, 2025

autosubmit label was removed for flutter/devtools/9409, because - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label.

@elliette elliette merged commit 5e17922 into flutter:master Aug 22, 2025
37 of 38 checks passed
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
@elliette @hrajwade96
Revert PR flutter#9372: Un-delete `packages/devtools_shared/lib/src/t…
a37b49d 
…est/chrome.dart` (flutter#9409)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srawlins srawlins srawlins approved these changes

@kenzieschmoll kenzieschmoll Awaiting requested review from kenzieschmoll kenzieschmoll is a code owner

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner

Assignees

No one assigned

Labels

release-notes-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elliette @srawlins