Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[ Hot Restart ] Fix possible hang due to unhandled exception in UI isolates on hot restart #165693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

[ Hot Restart ] Fix possible hang due to unhandled exception in UI isolates on hot restart #165693

merged 4 commits into from
Mar 26, 2025

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Mar 21, 2025

Possible fix for #161466

@bkonyi bkonyi requested review from chingjun and jyameo March 21, 2025 19:48
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 21, 2025
@bkonyi bkonyi mentioned this pull request Mar 21, 2025
Closed
@mraleph mraleph mentioned this pull request Mar 23, 2025
Closed
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 24, 2025

autosubmit label was removed for flutter/flutter/165693, because - The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 24, 2025

autosubmit label was removed for flutter/flutter/165693, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 26, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 26, 2025
Merged via the queue into master with commit 8297e44 Mar 26, 2025
142 checks passed
@auto-submit auto-submit bot deleted the possible_fix_for_161466 branch March 26, 2025 17:19
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 26, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
3bd7dac 
…in UI isolates on hot restart (flutter/flutter#165693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
aac3ccf 
…in UI isolates on hot restart (flutter/flutter#165693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
ed22427 
…in UI isolates on hot restart (flutter/flutter#165693)
@fredrik-smedberg
Copy link

I confirm, this definitely fixed my hot-reloading problems seen with Fluter 3.27.x and 3.29.x with iOS and Simulator.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
1267f12 
…in UI isolates on hot restart (flutter/flutter#165693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
5df6453 
…in UI isolates on hot restart (flutter/flutter#165693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
a3cae6e 
…in UI isolates on hot restart (flutter/flutter#165693)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
6fcceb5 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
0304a5e 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
85c3816 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
2aa3aa2 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
b08e2cf 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
51586b3 
…in UI isolates on hot restart (flutter/flutter#165693)
@DanTup DanTup mentioned this pull request Mar 31, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
f4ae513 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
7850752 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
0df900a 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
68f8700 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
b1610d2 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
f11fa5e 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
88eb595 
…in UI isolates on hot restart (flutter/flutter#165693)
@bkonyi bkonyi mentioned this pull request Apr 1, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
cbf329f 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
084a0c2 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
6061945 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
04413f6 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
4265adc 
…in UI isolates on hot restart (flutter/flutter#165693)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
8297e44 [ Hot Restart ] Fix possible hang due to unhandled exception …
ee08fe6 
…in UI isolates on hot restart (flutter/flutter#165693)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@bkonyi
[ Hot Restart ] Fix possible hang due to unhandled exception in UI is…
85dcef9 
…olates on hot restart (flutter#165693)

Possible fix for flutter#161466
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@bkonyi @romanejaquez
[ Hot Restart ] Fix possible hang due to unhandled exception in UI is…
2c0d256 
…olates on hot restart (flutter#165693)

Possible fix for flutter#161466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingjun chingjun chingjun approved these changes

@jyameo jyameo Awaiting requested review from jyameo

Assignees

No one assigned

Labels

cp: beta cherry pick this pull request to beta release candidate branch cp: stable cherry pick this pull request to stable release candidate branch tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bkonyi @fredrik-smedberg @chingjun