Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix regression in semantics update handling. #165842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Fix regression in semantics update handling. #165842

merged 3 commits into from
Mar 26, 2025

Conversation

@robert-ancell
Copy link
Contributor

@robert-ancell robert-ancell commented Mar 24, 2025

This was shown with the following errors in stdout: GLib-GObject-CRITICAL **: 11:41:35.775: invalid cast from 'FlEngine' to 'FlView'

This was broken in 554c814

@robert-ancell
Fix regression in semantics update handling.
b8c3b5d 
This was shown with the following errors in stdout:
GLib-GObject-CRITICAL **: 11:41:35.775: invalid cast from 'FlEngine' to 'FlView'

This was broken in 554c814
@robert-ancell robert-ancell requested a review from mattkae March 24, 2025 22:56
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 24, 2025

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Mar 24, 2025
mattkae
mattkae approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, but this looks good to me 👍

@robert-ancell robert-ancell added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 26, 2025

autosubmit label was removed for flutter/flutter/165842, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 26, 2025
@robert-ancell robert-ancell added this pull request to the merge queue Mar 26, 2025
Merged via the queue into flutter:master with commit 9b0c5c6 Mar 26, 2025
172 of 173 checks passed
@robert-ancell robert-ancell deleted the linux-semantics-callback-regression branch March 26, 2025 01:26
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
e22dddf 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
3e4e966 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
c1f1b1f 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
2717468 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
3446057 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
683868e 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
3b2645c 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
ed442fd 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
49ff65c 
…#165842)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
23c0ea6 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
8074856 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
2a7164a 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
8b1df1b 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
02a7f0a 
…#165842)
@Piinks Piinks mentioned this pull request Mar 28, 2025
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
b73e1b5 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
0bc1ec0 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
0854bba 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
7b96c88 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
f3fb7b7 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
b5b1ea4 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
1f5f5fb 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
16f8352 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
a6c8ba1 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
91d2a1c 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
94c9dc8 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
40c5dba 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
16941d7 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
baa6dbf 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
8c656a5 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
2dad3c5 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
69e73af 
…#165842)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
9b0c5c6 Fix regression in semantics update handling. (flutter/flutter…
521d047 
…#165842)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@robert-ancell
Fix regression in semantics update handling. (flutter#165842)
5a9b0bd 
This was shown with the following errors in stdout:
GLib-GObject-CRITICAL **: 11:41:35.775: invalid cast from 'FlEngine' to
'FlView'

This was broken in 554c814
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@robert-ancell @romanejaquez
Fix regression in semantics update handling. (flutter#165842)
a41188e 
This was shown with the following errors in stdout:
GLib-GObject-CRITICAL **: 11:41:35.775: invalid cast from 'FlEngine' to
'FlView'

This was broken in 554c814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-ancell @mattkae