Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move tracking of renderables from FlRenderer to FlEngine #165848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

Move tracking of renderables from FlRenderer to FlEngine #165848

merged 3 commits into from
Mar 26, 2025

Conversation

@robert-ancell
Copy link
Contributor

Motivated by work on refactoring FlRenderer to FlCompositor.

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically a: desktop Running on desktop labels Mar 25, 2025
mattkae
mattkae approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@robert-ancell robert-ancell added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 25, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 25, 2025

autosubmit label was removed for flutter/flutter/165848, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@robert-ancell robert-ancell added this pull request to the merge queue Mar 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 26, 2025
@robert-ancell robert-ancell enabled auto-merge March 26, 2025 03:10
@robert-ancell robert-ancell added this pull request to the merge queue Mar 26, 2025
Merged via the queue into flutter:master with commit b39232e Mar 26, 2025
171 of 172 checks passed
@robert-ancell robert-ancell deleted the linux-engine-renderables branch March 26, 2025 03:54
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
afdf8a8 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
67d7f55 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
349cceb 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
30558bf 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
b88eeeb 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
5863504 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
dd68181 
…tter/flutter#165848)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
9ff77f3 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
2a1a771 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
858eb62 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
391f309 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
2a0527d 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
67494e3 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
28266f7 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
8f5c25b 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
8b55c09 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
a2bdf79 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
fcef149 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
8e47dcc 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
19adbfa 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
6db90ca 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
858084a 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
03094f5 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
4a33611 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
dee2570 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
15c1cda 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
fc81728 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
64cbbd3 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
c97a9bb 
…tter/flutter#165848)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
b39232e Move tracking of renderables from FlRenderer to FlEngine (flu…
2b5ead5 
…tter/flutter#165848)
zhangyuang pushed a commit to zhangyuang/flutter-fork that referenced this pull request Jun 9, 2025
@robert-ancell
Move tracking of renderables from FlRenderer to FlEngine (flutter#165848
71007d8 
)

Motivated by work on refactoring FlRenderer to FlCompositor.
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@robert-ancell @romanejaquez
Move tracking of renderables from FlRenderer to FlEngine (flutter#165848
f644366 
)

Motivated by work on refactoring FlRenderer to FlCompositor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattkae mattkae mattkae approved these changes

@knopp knopp Awaiting requested review from knopp

@hbatagelo hbatagelo Awaiting requested review from hbatagelo

Assignees

No one assigned

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-linux Building on or for Linux specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-ancell @mattkae