Fix RenderPointerListener needsCompositing propagation from child widgets. #32717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf2f965 to
2e9f978
Compare
dkwingsmt
reviewed
May 14, 2019
2e9f978 to
02bc4d7
Compare
dkwingsmt
approved these changes
May 14, 2019
02bc4d7 to
a759759
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes propagation of
needsCompositingfrom child widgets.When
needsCompositingis turned on by a child widget, it necessarily sets theneedsCompositingbit of its parent widget, butRenderPointerListenerwas ignoring that piece of information and only turning on compositing if it thought it needed it for itself.This corrects that, and adds a test for the condition, and updates a test that was affected by the change.
Fixes #32525 (again)