Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix a problem in first focus determination. #33279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 1 commit into from
May 28, 2019
Merged

Fix a problem in first focus determination. #33279

gspencergoog merged 1 commit into from
May 28, 2019

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented May 23, 2019

Description

Replacing the algorithm for finding the first focusable item in the focus tree. Somehow it was a kind of gibberish before, and really didn't work or make sense.

Tests

I added the following tests:

  • Tests for both widget order and reading order traversal that find the first focus.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.
  • I checked all the boxes.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@gspencergoog gspencergoog requested a review from darrenaustin May 23, 2019 21:51
darrenaustin
darrenaustin approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification. LGTM.

@goderbauer goderbauer added the framework flutter/packages/flutter repository. See also f: labels. label May 23, 2019
@gspencergoog gspencergoog mentioned this pull request May 24, 2019
Merged
@Piinks
Copy link
Contributor

Piinks commented May 28, 2019

Is this ready to merge? :)

@gspencergoog
Copy link
Contributor Author

gspencergoog commented May 28, 2019

Yes. I was just waiting for green. Will merge shortly.

@gspencergoog gspencergoog merged commit 7c811b6 into flutter:master May 28, 2019
blasten pushed a commit to blasten/flutter that referenced this pull request May 30, 2019
@gspencergoog @blasten
Fix first focus determination. (flutter#33279)
fd31743 
Replacing the algorithm for finding the first focusable item in the focus tree. Somehow it was a kind of gibberish before, and really didn't work or make sense.
@gspencergoog gspencergoog deleted the fix_first_focus branch June 5, 2019 20:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gspencergoog @Piinks @darrenaustin @goderbauer @googlebot