-
Couldn't load subscription status.
- Fork 3.5k
[video_player] Implements background playback functionality #9212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution! Please see https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changing-federated-plugins for the process to make a multi-package PR, so that our CI can run tests. |
|
Thanks for the link, I missed that! I might be missing something very obvious here, but I'm not sure how to update so that the remaining checks will complete. From what I understand it fails due to a cached version of I can get the camera example to run locally, but only if I use direct dependencies instead of overridden dependencies. What's the best approach here? Should I just remove the path-based dependencies for the camera example or is there another way to resolve it? |
|
@stuartmorgan-g It looks like
@ArvidNy You should be able to fix this by manually adding the rest of the dependencies to the failing plugins. They should look like: dependency_overrides:
video_player: {path: ../../../../packages/video_player/video_player}
video_player_android: {path: ../../../../packages/video_player/video_player_android}
video_player_avfoundation: {path: ../../../../packages/video_player/video_player_avfoundation}
video_player_platform_interface: {path: ../../../../packages/video_player/video_player_platform_interface}
video_player_web: {path: ../../../../packages/video_player/video_player_web}Let me know if that works. |
Yes, the tooling should account for that though.
That shouldn't have been necessary. What command did you run, exactly, to generate what's in the PR now? |
|
This is the command I ran: dart run script/tool/bin/flutter_plugin_tools.dart make-deps-path-based --target-dependencies=video_player_platform_interface,video_player_android,video_player_avfoundation,video_player,video_player_web |
|
Oh, and manually adding the rest of the dependency overrides does seem to resolve the issue, at least locally. So I can push that to resolve the PR tests if there's no other obvious fix for it. |
|
I see the issue; I've filed flutter/flutter#168538 to track it. The best solution in the context of this PR is to revert all the non- |
… playback This PR is a subset of #9212 - it only adds platform interface changes. Partially resolves #62739. (#10054) Adds setter for allowing background playback This PR is a subset of #9212 - it only adds platform interface changes. Partially resolves #62739. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
|
Now that the interface PR landed, can you resolve the conflicts and let us know when it is ready for re-review? |
…terface dependency to version 6.5.0 across all packages
… for iOS; update comments for background playback handling
…ype; update related API interface and message handling
|
OK, I think it's finally ready for a re-review now. |
This pull request adds the missing implementation for background playback. This allows
video_playerto be used with e.g.audio_serviceto continue playing audio after the screen is closed or the app is move to the background. A sample implementation for testing can be found here: https://github.com/ArvidNy/video_player_audio_serviceCloses flutter/flutter#62739
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3