Allow rollout strategy to be configured in Helm charts #6447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run Status
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6447 +/- ##
=======================================
Coverage 58.47% 58.47%
=======================================
Files 940 940
Lines 71579 71579
=======================================
Hits 41858 41858
Misses 26538 26538
Partials 3183 3183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jason Parraga <[email protected]>
pingsutw
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #6446
Why are the changes needed?
This allows users to customize the rollout strategy of different flyte components.
What changes were proposed in this pull request?
Makes the rollout strategy configurable for different flyte components.
How was this patch tested?
It was not tested.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Summary by Bito
This pull request enhances Flyte deployment flexibility by introducing configurable rollout strategies for various components, including updates to deployment YAML files and adjustments to secrets and checksums. These modifications aim to improve customization and streamline the deployment process.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and well-documented, making the review process relatively quick.