Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move spatial cell to cpu-specific file#955

Merged
markusbattarbee merged 5 commits intofmihpc:devfrom
markusbattarbee:move_spatial_cell
Apr 26, 2024
Merged

Move spatial cell to cpu-specific file#955
markusbattarbee merged 5 commits intofmihpc:devfrom
markusbattarbee:move_spatial_cell

Conversation

@markusbattarbee
Copy link
Contributor

This introduces a spatial_cell wrapper which should aid with making sense of the future GPU branch PR.

@markusbattarbee markusbattarbee marked this pull request as draft April 26, 2024 05:49
@markusbattarbee markusbattarbee marked this pull request as ready for review April 26, 2024 07:15
@ursg
Copy link
Contributor

ursg commented Apr 26, 2024

This is only boilerplate change so far, right? Files were renamed and includes adapted and all types still have the same name, as far as I can see.

What's the next step then? Will mpiGrid continue to carry "spatialCell" as its contents, meaning the CPU-side version? Or will that have some typename change (and thus major refactoring everywhere)?

@markusbattarbee
Copy link
Contributor Author

markusbattarbee commented Apr 26, 2024

This is indeed boilerplate change, so that when the GPU pull request comes in, it'll be easier to see and evaluate the changes. This should help with the fact that Github doesn't deal well with showing changes when there's simultaneously

  • renaming a file (spatial_cell.hpp -> spatial_cell_cpu.hpp)
  • changes to contents (the above file)
  • a new file with a same name as the old one (wrapper spatial_cell.hpp - thus making it explicitly spatial_cell_wrapper.hpp)

So this PR does the first and the last (making it explicitly _wrapper.hpp), so that when the second point is in the GPU PR, we see what's going on.

Copy link
Contributor

@ursg ursg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then, looks good to me!

@markusbattarbee markusbattarbee merged commit 24f3c53 into fmihpc:dev Apr 26, 2024
@markusbattarbee markusbattarbee deleted the move_spatial_cell branch May 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments