Thanks to visit codestin.com
Credit goes to github.com

Skip to content

msvc + ninja + modules: Fix build when consuming fmtlib while using a Ninja generator#4495

Merged
vitaut merged 1 commit intofmtlib:masterfrom
autoantwort:fix-modules-with-msvc-and-ninja
Jul 13, 2025
Merged

msvc + ninja + modules: Fix build when consuming fmtlib while using a Ninja generator#4495
vitaut merged 1 commit intofmtlib:masterfrom
autoantwort:fix-modules-with-msvc-and-ninja

Conversation

@autoantwort
Copy link
Contributor

@autoantwort autoantwort commented Jul 12, 2025

Fixes #4491.

Generator fmtlib -> consumer Type Old New
VS -> VS * Works Works
VS -> Ninja find_package Works Works
VS -> Ninja add_submodule Broken Works
Ninja -> VS find_package Broken Broken
Ninja -> VS add_submodule Works Works
Ninja -> Ninja find_package Broken Works
Ninja -> Ninja add_submodule Broken Works

@vitaut vitaut merged commit a0ecfe3 into fmtlib:master Jul 13, 2025
40 checks passed
@vitaut
Copy link
Contributor

vitaut commented Jul 13, 2025

Thank you

@autoantwort autoantwort deleted the fix-modules-with-msvc-and-ninja branch July 13, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when using installed c++ module with MSVC

2 participants

Comments