Fix MNE example to work with MNE 1.3#259
Merged
TomDonoghue merged 3 commits intofooof-tools:mainfrom Jun 29, 2023
Merged
Conversation
Member
|
Hey @charlesincharge - thank you for catching & fixing this! Sorry for a bit of a delay in getting back to you in this - we are currently working on a push to merge some updates, so I checked through this and made some direct edits / additions. For tracking, what I updated is:
I'm going to merge this in now, but if you have any thoughts / comments on the updates, feel free to add some comments! Thank you for your contribution to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MNE 1.3 has fully deprecated
psd_welch. Following the MNE 1.2 deprecation suggestion: https://mne.tools/1.2/generated/mne.time_frequency.psd_welch.html , I replaced it with.compute_psd(method="welch")Additionally, paths are now returned using
pathlib.Path, notstr.I ran this locally to check, and it works with MNE 1.3.1